Skip to content

NEVER use dynamic tag names #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2017
Merged

NEVER use dynamic tag names #525

merged 1 commit into from
Jan 17, 2017

Conversation

SUPERCILEX
Copy link
Collaborator

@SUPERCILEX
NEVER use dynamic tag names
8d79634 
Signed-off-by: Alex Saveau <[email protected]>
@SUPERCILEX SUPERCILEX mentioned this pull request Jan 16, 2017
Merged
@puf
Copy link
Contributor

puf commented Jan 16, 2017

LGTM, but please copy your comment from #488 (comment) here. Or create an issue for the problem of course. :-)

@SUPERCILEX
Copy link
Collaborator Author

Copied comment:

@puf This isn't so much needed in FirebaseListAdapter, but this is a massive no-no in the FirebaseRecyclerAdapter where the name is 23 characters long. I made this tag in one of my first PRs and I really regret it: if someone were to create a tag using getSimpleName() in FirebaseIndexRecyclerAdapter, Log.anything will throw an exception because the tag name exceeds 24 characters. You should NEVER use dynamic tag names for that reason.

@samtstern
Copy link
Contributor

Yep LGTM, thanks for the fix!

@samtstern samtstern merged commit 81e93bf into firebase:master Jan 17, 2017
@SUPERCILEX SUPERCILEX deleted the db-tags branch January 17, 2017 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SUPERCILEX @puf @samtstern